[Webkit-unassigned] [Bug 15374] New: RenderBox::availableHeightUsing() contains left/right -> top/bottom typo

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15374

           Summary: RenderBox::availableHeightUsing() contains left/right ->
                    top/bottom typo
           Product: WebKit
           Version: 312.x
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: NeedsReduction
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: hyatt at apple.com, mitz at webkit.org


Whilst investigating a fix for Bug 15359, I noticed that
RenderBox::availableHeightUsing() seems to be using the wrong margin/padding
attributes for calculating height:

return overrideSize() - (borderLeft() + borderRight() + paddingLeft() +
paddingRight());

I believe this line of code should be:

return overrideSize() - (borderTop() + borderBottom() + paddingTop() +
paddingBottom());

After making this change, though, no layout tests failed (as of r25955), so
this code is not being adequately tested.  If this is the correct fix, a layout
test should be written to tickle this code.

Note that this code was originally committed in r3351 (search for
"artificially"):

http://trac.webkit.org/projects/webkit/changeset/3351#file17


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.