[Webkit-unassigned] [Bug 15691] [GTK] Public API does not follow GTK+ conventions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 30 17:00:09 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15691





------- Comment #22 from alp at atoker.com  2007-11-30 17:00 PDT -------
(In reply to comment #18)
> (In reply to comment #15)
> > Created an attachment (id=17613)
 --> (http://bugs.webkit.org/attachment.cgi?id=17613&action=view) [edit]
> > Refactor as planned
> 
> This is starting to look good. However allow me a few comments.
> 
> > WebKitWebFrame* webkit_web_frame_init_with_web_view(WebKitWebView* webView, HTMLFrameOwnerElement* element)
> 
> I believe this is meant to be static. And while you're at it you might give it
> a n appropriate name, such as webkit_web_frame_init_with_element.
> 
> > WebKitWebView* webkit_web_frame_get_web_view(WebKitWebFrame* frame)
> This should return GtkWidget*.
> 
> > +void webkit_web_view_go_backward(WebKitWebView* webView)
> This should be s/backward/back. 
> 
> > WebKitSettings* webkit_web_settings_copy
> This doesn't match, it should return WebKitWebSettings*.
> 
> > WebKitWebView != webkit_web_view
> This capitalization is errorneous, WebkitWebView would be correct for
> webkit_web_view.
> 

If you look at the ChangeLog entry you'll find this patch deals only with
refactoring WebKitPage -> WebKitWebView and WebKitFrame -> WebKitWebFrame.

The capitalisation is actually more correct this way. All language binding
generators I know of deal fine with this case.

The other issues sound valid and should be fixed in individual patches, or at
least not in this one.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list