[Webkit-unassigned] [Bug 16202] Optimize allocation of ActivationImp objects

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16202





------- Comment #4 from cwzwarich at uwaterloo.ca  2007-11-30 15:13 PDT -------
(In reply to comment #2)
> The analysis here seems generally sound. I said on IRC that I'm not sure you
> need to tear off in cases 2 and 3. But you may want to anyway, since then
> tearoff is always for the current top of the scope chain, even though sometimes
> it happens before the moment a closure truly needs it.

Cases 2 and 3 push an object on the top of the scope chain, so that when we
would go to tear off an ActivationImp upon seeing a function expression, we
would have to change pointers to the ActivationImp further up the scope chain.
Am I incorrect here?

(In reply to comment #3)
> In the general case, where we don't need an ActivationImp, I think we can just
> put LocalStorage directly into the stack-allocated ExecState. When we do need
> an ActivationImp, we can allocate it, and move LocalStorage from the ExecState
> to the ActivationImp.

Doesn't JavaScriptCore already have stack space issues? Is there a consensus
that this is the best idea?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.