[Webkit-unassigned] [Bug 16195] New: REGRESSION: JavaScriptCore and LayoutTest failures

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16195

           Summary: REGRESSION: JavaScriptCore and LayoutTest failures
           Product: WebKit
           Version: 523.x (Safari 3)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: Regression
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


http://build.webkit.org/builders/trunk-mac-ppc-release/builds/9420

This was caused by:
http://trac.webkit.org/projects/webkit/changeset/28186

Which was a fix for:
http://trac.webkit.org/projects/webkit/changeset/28151

r28151 had incorrectly removed { } from an if/else block, leading to the crash.
 I fixed that, but either something was wrong in my fix (r28186) or that fix
exposed some other bug.  Unfortunately the fixes aren't properly ordered, so
it's hard to figure out if that uncovered some other bug.

I failed to run *all* of the tests after preparing r28186, I was only running
the crashing test at the time.  Oops.

When I get around to fixing this, I'll do so by reordering the commits on a
local git branch and squashing 28186 on top of 28151 and then running
git-bisect against the whole set of PCRE fixes looking for where these new
regressions occurred.  Then I'll just stare at the diff until I find the
unintended logical change, or I'll use the diffs in the test results to guide
me to the right area.

Unfortunately I don't have a fully functional computer and internet setup right
now (I'm setting up my new apartment) so it might be a day or more before I get
to sit down and fix this.  If I'm on IRC (as MacDome) you might want to ask me
if I'm working on it before you do.  If I'm not on IRC, I won't be working on
it. :)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.