[Webkit-unassigned] [Bug 16159] String optimization- remove realloc from StringImpl::adopt

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16159


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org




------- Comment #1 from ap at webkit.org  2007-11-28 11:06 PDT -------
(In reply to comment #0)
> There is a potential downside to this; if the vector being adopted had a large
> unused capacity, then this call would no longer reclaim that extra space. 

I think that this is exactly the reason why the buffer is reallocated - the
vector capacity is doubled as it runs out of space, so it's quite common to
have a lot of extra capacity.

The performance impact may make us reconsider this. Could you please attach a
patch and mark it for review, as described in
<http://webkit.org/coding/contributing.html>?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.