[Webkit-unassigned] [Bug 16115] [GTK] ContextMenu and ContextMenuItem lacks an implementation

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16115





------- Comment #1 from freyther at handhelds.org  2007-11-25 08:39 PDT -------
Created an attachment (id=17507)
 --> (http://bugs.webkit.org/attachment.cgi?id=17507&action=view)
ContextMenu Implementation WIP

Known issues or not yet checked:
  - Is the ref counting done right? Should we sink it? Should we just ref it?
  - We exploit the GObject to attach ContextMenuAction to a GtkMenuItem. We
could keep them mapping in a hash map but would we store it in ContextMenu or
ContextMenuItem.
  - How to map that into an API?
  - The code to activate the context menu by keyboard (in webkitgtkpage.cpp) is
mostly taken from the Windows port. It would be nice to share some of the
calculations to find the right element.
  - We need to morph a GtkMenuItem to a GtkCheckMenuItem on the fly. So it
might make sense to not create a GtkMenuItem in ContextMenuItem until we need
it or not at all. With the internal API we do not know what we are going to be.

Anyway with this patch you can right click and see a context menu.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.