[Webkit-unassigned] [Bug 14809] [gtk] Implement settings as properties of WebKitGtkPage

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14809


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




------- Comment #5 from xan.lopez at gmail.com  2007-11-25 07:34 PDT -------
(In reply to comment #2)
> Created an attachment (id=16870)
 --> (http://bugs.webkit.org/attachment.cgi?id=16870&action=view) [edit]
> Many more properties, style cleanup
> 
> This revision of the patch implements many more properties. Further more the
> code was cleaned up style wise.
> 

Some comments:

- PROP_0 is generally used instead of PROP_NULL.
- Unneeded blank lines in the switch constructs.
- The first parameter of the param_spec functions is the canonical name of the
property, which has to follow some syntactic rules. The second is the
"nickname", which is generally the canonical name with s/-/ / and properly
capitalized. The third one is a human readable description explaining what this
property is about.
- You use lots of magic numbers :|

Other than that, looks good to me.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.