[Webkit-unassigned] [Bug 16128] ignore resizable=no for window.open()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 00:52:18 PST 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #17502|review?                     |review-
               Flag|                            |

------- Comment #2 from aroben at apple.com  2007-11-25 00:52 PDT -------
(From update of attachment 17502)
+    // Ignore resizable key
+    //    else if (keyString == "resizable")
+    //        windowFeatures.resizable = value;

We don't like to leave commented-out code in our source tree. Having a comment
about ignoring resizable is good (perhaps at the start of this if/else chain),
but the code should just be removed.

+    // Default to true
+    windowFeatures.resizable = true;

This comment should be omitted, as it add any information to the code below it.

Should we just remove windowFeatures.resizable entirely?

r- so the above issues can be fixed.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list