[Webkit-unassigned] [Bug 16124] Add printf format attribute to several functions to fix some GCC warnings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 24 19:08:31 PST 2007
http://bugs.webkit.org/show_bug.cgi?id=16124
mjs at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #17493|review? |review-
Flag| |
------- Comment #2 from mjs at apple.com 2007-11-24 19:08 PDT -------
(From update of attachment 17493)
Substance of the change looks good. A few comments on style:
1) We usually use #if COMPILER(GCC) rather than #if __GNUC__
2) It might be a good idea to make a macro that's defined to either the right
attribtue or nothing depending on the compiler, to avoid sprinking the code
with compiler #ifdefs.
Please make those adjustments (feel free to also fix existing uses of the
printf attribute).
r- for now, will gladly re-review with those fixes.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list