[Webkit-unassigned] [Bug 6129] Incomplete implementation of CSS 2.1 system colors

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=6129


proton at wiretapped.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16501|0                           |1
        is obsolete|                            |
  Attachment #17440|                            |review?
               Flag|                            |




------- Comment #14 from proton at wiretapped.net  2007-11-22 02:41 PDT -------
Created an attachment (id=17440)
 --> (http://bugs.webkit.org/attachment.cgi?id=17440&action=view)
Proposed patch 2

Changed the design to use the lookup table again, decided the design that used
the unlabelled values in colorValues wasn't as nice as the proper pairs. This
let gray/grey go back into the normal lookup.

The values that are 256 are that specifically because otherwise a number of
colours end up rounding in such a way that values are off-by-one. Perhaps we
should add a comment to the code to indicate this as it's a little unusual that
it's not 255?

Added early return to RenderThemeMac::systemColor.

As to website compatibility, on Mac OS X at least all colours that feature in
layout tests in this are the same except that the control grey would change
from 0xC0C0C0 to 0xECECEC. Should we go with this change, or just hard code the
old value instead of using [NSColor controlColor] for it?

No changelog/layout tests until the above questions are answered (the layout
test changes are fairly long with the change from 0xC0C0C0 to 0xECECEC. I'll
add them back when we get them answered :-)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.