[Webkit-unassigned] [Bug 15530] XMLHttpRequest should not support certain methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 07:55:42 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15530


julien.chaffraix at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17429|0                           |1
        is obsolete|                            |
  Attachment #17430|                            |review?
               Flag|                            |




------- Comment #3 from julien.chaffraix at gmail.com  2007-11-21 07:55 PDT -------
Created an attachment (id=17430)
 --> (http://bugs.webkit.org/attachment.cgi?id=17430&action=view)
Patch updated with Ap's comments

> (From update of attachment 17429 [edit])
> +    layoutTestController.waitUntilDone();

> This is not needed.

Removed.

> +    try {
> +        xhr.open(method, "resources/1251.html", true);
> +        xhr.send(null);

> This test doesn't differentiate between open() and send() raising an
> exception,
> I think it should.

In fact, the exception should be raised only for open() so I removed send() as
it was not relevant.

> It may be slightly better to use sync XHR in the test, to maqke it more
> explicit that we don't wait for anything to finish.

The new test case uses a sync XHR.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list