[Webkit-unassigned] [Bug 16052] prepare-ChangeLog doesn't report deleted files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 23:33:57 PST 2007


------- Comment #6 from ddkilzer at webkit.org  2007-11-19 23:33 PDT -------
(In reply to comment #4)
> I'm using svn. I don't have git on my machine, and I removed the files with svn
> remove path/to/file, so I'm not sure how it could be an issue with git in my
> case. Are you sure it handles files removed in svn correctly? Because neither
> the isAdded or isModified functions check for the "D" status, and if those
> functions don't return true, then how is the file added to @changedFiles?

I see the issue now.  (I'll file a separate bug on the git issue.)

If you only have deleted files in the tree, then generateFileList() returns no
changes and the script exits.

1. svn rm WebKitTools/mangleme/README
2. ./WebKitTools/Scripts/prepare-ChangeLog WebKitTools

To undo these changes (for any new svn users reading this):
svn revert WebKitTools/ChangeLog  WebKitTools/mangleme/README

However, we don't want to add removed (deleted) files to @changed_files since
this is used to create a list of added/changed method names for source files.

After playing with the script for a while, I think the "No changes found." test
is broken.  It currently reads:

if (!@changed_files && !@conflict_files || !%function_lists) {

I think it should read:

if (!@changed_files && !@conflict_files && !scalar keys %function_lists) {

I believe that should fix the issue.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list