[Webkit-unassigned] [Bug 16052] prepare-ChangeLog doesn't report deleted files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 23:01:26 PST 2007


------- Comment #4 from kevino at theolliviers.com  2007-11-19 23:01 PDT -------
(In reply to comment #2)
> (From update of attachment 17402 [edit])
> Marking r- since this is the wrong fix.
> The prepare-ChangeLog script already reports removed files for svn.
> I just realized that the actual bug is that prepare-ChangeLog ignores changes
> staged to the index for git.  For example, if you use "git rm path/to/file"
> instead of "rm path/to/file", the prepare-ChangeLog script ignores this change
> since it doesn't use the --cached switch on git-diff.
> Also, if you git-add changed files before running prepare-ChangeLog, those
> changes won't be seen, either.
> Should we be running git-diff with and without "--cached", or should we be
> looking at the output of git-status and parsing both of its sections?
> Kevin, are you using svn or git?  Does the above explain the issue you're
> seeing?

I'm using svn. I don't have git on my machine, and I removed the files with svn
remove path/to/file, so I'm not sure how it could be an issue with git in my
case. Are you sure it handles files removed in svn correctly? Because neither
the isAdded or isModified functions check for the "D" status, and if those
functions don't return true, then how is the file added to @changedFiles?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list