[Webkit-unassigned] [Bug 16052] prepare-ChangeLog doesn't report deleted files

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16052


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17402|review?                     |review-
               Flag|                            |




------- Comment #2 from ddkilzer at webkit.org  2007-11-19 22:43 PDT -------
(From update of attachment 17402)
Marking r- since this is the wrong fix.

The prepare-ChangeLog script already reports removed files for svn.

I just realized that the actual bug is that prepare-ChangeLog ignores changes
staged to the index for git.  For example, if you use "git rm path/to/file"
instead of "rm path/to/file", the prepare-ChangeLog script ignores this change
since it doesn't use the --cached switch on git-diff.

Also, if you git-add changed files before running prepare-ChangeLog, those
changes won't be seen, either.

Should we be running git-diff with and without "--cached", or should we be
looking at the output of git-status and parsing both of its sections?

Kevin, are you using svn or git?  Does the above explain the issue you're
seeing?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.