[Webkit-unassigned] [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15669


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17403|review?                     |review-
               Flag|                            |




------- Comment #9 from alp at atoker.com  2007-11-19 12:05 PDT -------
(From update of attachment 17403)
>Index: WebCore/WebCore.pro
>===================================================================
>--- WebCore/WebCore.pro	(revision 27906)
>+++ WebCore/WebCore.pro	(working copy)
>@@ -91,6 +91,11 @@ DEPENDPATH += editing/qt history/qt load
> }
> 
> gtk-port {
>+!mac:!win32-* {
>+    DEFINES += XP_UNIX
>+    LIBS += -lXt
>+}

The assumption that !mac:!win32-* implies that X11 is available is incorrect.
The core of the GTK+ port is windowing-system neutral, so features specific to
X11 need to be added with care.

I'm also not convinced that we want to link to Xt by default even when X11 is
available. Can we make plugin support an optional feature?

Thanks.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.