[Webkit-unassigned] [Bug 16049] execCommand('backColor') fails on collapsed selections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 08:11:45 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=16049





------- Comment #1 from mrowe at apple.com  2007-11-19 08:11 PDT -------
JSEditor.cpp shows that BackColor and ForeColor have different values for the
enabledFn member of their CommandImp:

WebCore/editing/JSEditor.cpp:        { "BackColor", { execBackColor,
enabledAnyRichlyEditableRangeSelection, stateNone, valueBackColor } },
WebCore/editing/JSEditor.cpp:        { "ForeColor", { execForeColor,
enabledAnySelection, stateNone, valueForeColor } },


BackColor requires a range selection which would cause the command to be
disabled for collapsed selections.  The fix here may be as simple as changing
the enabledFn to enabledAnyRichlyEditableSelection.  A quick test suggests that
this gives the same behaviour as IE on the test case.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list