[Webkit-unassigned] [Bug 16036] Further cleanup to PCRE

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16036


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17349|                            |review-
               Flag|                            |




------- Comment #40 from sam at webkit.org  2007-11-18 19:32 PDT -------
(From update of attachment 17349)
The * should go next to the type here.
+static int find_fixedlength(uschar *code, int options)

and here
+    uschar *cc = code + 1 + LINK_SIZE;

I think should be while (true) for consistency.
+    for (;;) {

Brace should go on the same line as the switch statement.
+        switch (op)
+        {

I think spliting this onto multiple lines will make it more clear. (appears
twice)
+                do cc += GET(cc, 1); while (*cc == OP_ALT);

In the inner switch statement you indent the cases differently than the outer
switch.  Consistency is the key.
+                switch (*cc) {
+                case OP_CRSTAR:

r-


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.