[Webkit-unassigned] [Bug 15938] Inspector/Qt requires patch to SecurityOrigin

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15938





------- Comment #6 from freyther at handhelds.org  2007-11-18 12:10 PDT -------
(In reply to comment #5)
> (From update of attachment 17243 [edit])
> The additional string allocation from calling left() on the URL string will
> almost certainly cause an unacceptable slowdown; there's a reason we added
> those special cases for "http" and "file" to avoid memory allocation.

I don't wear my Knuth is my homeboy T-Shirt but seeing numbers would be
appreciated. E.g. is FrameLoader calling the Scheme version more often than
Document and CachedResource the URL version? I admit to have not researched the
details of the original function because I assume(d) that the tests are not
public.


> 
> The concept of the patch is fine, but we need a more efficient version.

This boils down to:
   a) Code duplication?
   b) Better data structure for the local schemes. e.g. a Trie?
   c) Something I miss.


So what solution is preferred?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.