[Webkit-unassigned] [Bug 16026] GC: Using != when comparing pointers when marking stack objects can cause segfaults

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16026


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17328|review?                     |review-
               Flag|                            |




------- Comment #6 from darin at apple.com  2007-11-17 15:33 PDT -------
(From update of attachment 17328)
If memory is not aligned correctly, there are other problems besides the loop
termination condition. For example, the garbage collector will miss pointers on
the stack and collect objects that are actually in use.

So while this patch is harmless for platforms where things are already correct,
it's not actually sufficient to fix your port.

I suggest further investigation of why you don't have alignment. A larger
change may be necessary if the storage on the stack is not guaranteed to be
aligned -- you may need to walk the stack 2 bytes at a time or even 1 byte at a
time, in which case you'll need to change more than just this loop termination
condition.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.