[Webkit-unassigned] [Bug 16024] prepare-Changelog needs to use git repo-config if git config fails
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 16 22:06:05 PST 2007
http://bugs.webkit.org/show_bug.cgi?id=16024
ddkilzer at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #17326|review? |review-
Flag| |
------- Comment #3 from ddkilzer at webkit.org 2007-11-16 22:06 PDT -------
(From update of attachment 17326)
> my $result = `$GIT config $config`;
>+ if ($result =~ /is not a git-command/) {
>+ $result = `$GIT repo-config $config`;
>+ }
I think it would be best to check the exit value of the backtick command
instead of the error text:
if (($? >> 8) != 0) {
Also, please use the same indention rules as the rest of the script.
Please make these changes and repost. Thanks!
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list