[Webkit-unassigned] [Bug 12194] Trying to access XMLHttpRequest.responseText or responseXML when they are not available should raise an exception

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12194


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17309|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-11-16 20:08 PDT -------
(From update of attachment 17309)
+            if (responseXML)
                 return toJS(exec, responseXML);
-            return jsNull();
+            else
+                return jsNull();

We normally do *not* do else after return in the WebKit project.

+    if (m_state < Receiving) {
+        ec = INVALID_STATE_ERR;
+    }

We do not put braces around single-line bodies of if statements.

+Should see "PASS" four times:
+
+PASSED
+PASSED
+PASSED
+PASSED

Probably should say "PASSED" or "PASS" consistently.

Change looks good, so I'll say r=me, but it would be nice to fix these minor
style issues.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.