[Webkit-unassigned] [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 11:05:25 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15669


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17315|review?                     |review-
               Flag|                            |




------- Comment #4 from mrowe at apple.com  2007-11-16 11:05 PDT -------
(From update of attachment 17315)
It turns out that npapi.h is a public API header file so we can't do the
#undef's there.  What we'll need to do is add a new header file to
JavaScriptCore that includes npapi.h and Xresources.h and then #undef's the
relevant values.  Places inside JavaScriptCore/WebCore/WebKit that include
npapi.h should then be updated to include that wrapper header file instead.

One issue is that npruntime.h, another public API header file, includes npapi.h
and we clearly can't include our wrapper header in that.  It may be required to
wrap npruntime.h instead of npapi.h and move anyone that includes npapi.h or
npruntime.h directly to the wrapper.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list