[Webkit-unassigned] [Bug 15976] Throwing an exception within Database.transaction ASSERTs then crashes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15976





------- Comment #5 from beidson at apple.com  2007-11-13 21:22 PDT -------
> Do we need to localize this string? 
no (not required, and we don't for any other DOM error messages)

> Should "the" be capitalized? 
no (we don't for any other DOM error messages)

> Where is this text used?
Wherever the web developer chooses - it's an attribute on the SQLError they
get, in addition to the error code (0, in this case)

> It doesn't look like m_transactionError gets set everywhere
deliverTransactionErrorCallback() is called -- do we need to do it elsewhere?
What's the rule?

Actually it was set everywhere else - The only other entry point to
deliverTransactonErrorCallback() is through handleTransactionError(), and a
quick audit of each site that calls that shows the error being set first.

This was a unique case, jumping from one callback straight to the error
callback.  What the assertion was designed to catch!

I overlooked the fact that this was easily layout-testable since I still
haven't gotten to DRT infrastructure for a real database test suite, whereas
this one is just a "crash or doesn't" test.  I will add that and put a new
patch up


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.