[Webkit-unassigned] [Bug 15973] New: Use templates to clean up comparison node code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 16:36:24 PST 2007


           Summary: Use templates to clean up comparison node code
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org

Use templates to clean up comparison node code

The end goal is to move to op-code generation for a byte-code interpreter.  In
many existing Node evaluate* calls we do the same set of operations:
1. convert the inputs to a base type we know how to handle
2. do whatever is specific to that node
3. convert the output to whatever type was requested by the caller.

I'm trying to get ride of steps 1. and 2. and leave us only with step 3.  Steps
1. and 2. are basically copy/paste code and will end up as standard op-code
groups which are re-used by lots of Nodes in the bytecode interpreter.

I've attached a patch for comment.  It's not a perfect solution, but I think
it's a good start.  I'm not sure the template usage is exactly as I want it to
be in the end.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list