[Webkit-unassigned] [Bug 15938] Inspector/Qt requires patch to SecurityOrigin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 16:05:05 PST 2007


freyther at handhelds.org changed:

           What    |Removed                     |Added
  Attachment #17243|                            |review?
               Flag|                            |

------- Comment #4 from freyther at handhelds.org  2007-11-13 16:05 PDT -------
Created an attachment (id=17243)
 --> (http://bugs.webkit.org/attachment.cgi?id=17243&action=view)
Add FrameLoader::shouldTreatSchemeAsLocal

Altnernative implementation. Add FrameLoader::shouldTreatSchemeAsLocal and call
it with KURL::protocol from within FrameLoader and SecurityOrigin when we have
a KURL. In CachedResource and Document we continue to use the
shouldTreatURLAsLocal function as we have (Deprecated)Strings there.

This function is doing the splitting of the URL first before it is comparing
file and http as fast path. And due not using .find in shouldTreatSchemeAsLocal
we need to check for the null string otherwise we end up with a crash in the

This introduces no regressions and I would welcome feedback and specially in
regard to Performance and Correctness.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list