[Webkit-unassigned] [Bug 15891] [GTK] Javascript console and dialogs are not implemented

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15891





------- Comment #13 from alp at atoker.com  2007-11-13 04:15 PDT -------
I think this patch is basically there. I have one last thought before we land
this.

There are a bunch of people looking to support languages other than JavaScript
in WebKit, and the new scripting languages will probably still support
alert/confirm/prompt, so they will use the same signals.

Maybe we should refactor the naming to "script_prompt" or even just "prompt"
etc.? This is a slight deviation from what WebCore does but it seems to make
sense.

I got the inspiration from this Mozilla code:

    val = g_signal_connect(G_OBJECT(engine), "alert",
                           G_CALLBACK(alert_cb), self);
    g_mozilla_engine_array_insert_signal(self, val);

    val = g_signal_connect(G_OBJECT(engine), "prompt",
                           G_CALLBACK(prompt_cb), self);
    g_mozilla_engine_array_insert_signal(self, val);

    val = g_signal_connect(G_OBJECT(engine), "confirm",
                           G_CALLBACK(confirm_cb), self);
    g_mozilla_engine_array_insert_signal(self, val);

    val = g_signal_connect(G_OBJECT(engine), "confirm_ex",
                           G_CALLBACK(confirm_ex_cb), self);
    g_mozilla_engine_array_insert_signal(self, val);

http://garage.maemo.org/plugins/scmsvn/viewcvs.php/mozilla/trunk/microb-eal/src/gmozillaengine.c?root=browser&view=markup


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.