[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 15:46:00 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15960





------- Comment #1 from anyang.ren at gmail.com  2007-11-12 15:46 PDT -------
Created an attachment (id=17215)
 --> (http://bugs.webkit.org/attachment.cgi?id=17215&action=view)
Preliminary patch for discussion

This patch is intended to indicate the location of the bug and suggest a
possible fix.
I don't know the code well enough to know if this fix is correct.

I first tried removing the currAttr++ if statement, but that broke the
"!DOCTYPE" tag.
So in this patch I moved the currAttr++ if statement into the if (doctype)
block.

I wonder if we can simply do currAttr++ without checking if attr->value() is
null or empty:

                            if (doctype) {
                                addText(name, "webkit-html-doctype");
                                currAttr++;
                            } else {


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list