[Webkit-unassigned] [Bug 15950] Add evaluateToInt32 and evaluateToUInt32 methods to ExpressionNode subclasses

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 14:06:37 PST 2007


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #17199|0                           |1
        is obsolete|                            |

------- Comment #2 from eric at webkit.org  2007-11-12 14:06 PDT -------
Created an attachment (id=17212)
 --> (http://bugs.webkit.org/attachment.cgi?id=17212&action=view)
better fix (still 0.1% regression overall, large speedup for math, slowdown for
few tests)

I'm not quite sure where to go next with this patch, w/o going off in a totally
different direction to make it a speedup.  Shark "compare" seems to report that
the extra time on the regressed tests is spent in
LocalVarAccessNode::evaluateToInt32, but that time should just be moved from
the callsites where the callers no longer have to call toInt32().  Maybe the
compiler has more trouble with the toInt calls in such a small function since
it can't reorder the instructions to avoid stalls.  That's a totally unfounded
guess however.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list