[Webkit-unassigned] [Bug 15813] Incorrect handling of findstr results in *.vcproj

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15813


hnakamur at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17014|0                           |1
        is obsolete|                            |
  Attachment #17176|                            |review?
               Flag|                            |




------- Comment #9 from hnakamur at gmail.com  2007-11-10 16:40 PDT -------
Created an attachment (id=17176)
 --> (http://bugs.webkit.org/attachment.cgi?id=17176&action=view)
Fix handling results of findstr

First, "echo on" was my mistake. I forgot removing them.

As for ERRORLEVEL, I read the help of cmd.exe and understand that "if
ERRORLEVEL n stmt1 else stmt2" means if errorlevel is greater than or equal to
n then execute stmt1 else execute stmt2. And findstr returns 0 when found, 1
when not found. So if you write "if ERRORLEVEL 0", stmt1 is always executed.

Also you need parenthesis if stmt1 is not one word. I tried without parenthesis
and it didn't work correctly. I tried on Japanese Windows Vista Home Edition.

And original project file was missing "else" for setting AnalyzeWithLargeStack.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.