[Webkit-unassigned] [Bug 15891] Javascript console and dialogs are not implemented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 01:48:33 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15891





------- Comment #7 from xan.lopez at gmail.com  2007-11-10 01:48 PDT -------
(In reply to comment #5)
> Well, at first I did provide the handlers via G_STRUCT_OFFSET but this meant
> that they are always executed. And we want to allow clients to override the
> signals. So I left it blank here. It does work fine for me, tested with and
> without signals connected by a client.

You don't do it like that. Make the signal have boolean return value, if the
clients want to override the default handler they connect to the signal and
return TRUE in their callback.

> 
> > Also, why did you set alert and console-message as returning void? Doesn't that
> > mean the default handler will be executed unless you stop the emission manually
> > from a callback? For console-message I suppose it's ok, but why for alert?
> 
> The default handler is only executed if there are no client signals connected.
> I found it a bit nicer api wise to do the magic in the background so that the
> return values can actually be used.

Same than above.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list