[Webkit-unassigned] [Bug 15917] New: Reduce the insanity that is ArrayNode/ElementNode

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15917

           Summary: Reduce the insanity that is ArrayNode/ElementNode
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


Reduce the insanity that is ArrayNode/ElementNode

Bleh.  This patch (partially) cleans up ArrayNode/ElementNode.  In the end
ElementNode doesn't really need to exist, elision information could be stored
on the ArrayNode.  Certainly ElementNode doesn't need to have its virtual
functions (evaluate or otherwise).

This patch does some small cleanup.  Including renaming "elision" (meaningless
to most of us in this context) to "m_extraTrailingCommas" and
"m_extraLeadingCommas" better describing what it actually refers to.  The
unneeded "opt" special-case variable is also removed.

A next-pass would remove ElementNode::evaluate entirely, and just let the
ArrayNode walk through the list instead of making it recursive.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.