[Webkit-unassigned] [Bug 14893] WebKit confuses width/height for Media Queries device-aspect-ratio evaluation

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14893





------- Comment #5 from ddkilzer at webkit.org  2007-11-06 19:15 PDT -------
(In reply to comment #4)
> Actually, I believe the current code is correct (but with poorly-named
> variables).  We should be cross-multiplying the values to compare them, which
> the current code does.
> 
> http://www.w3.org/TR/css3-mediaqueries/#device-aspect-ratio

The current code is incorrect, but so is the patch (Attachment #15853).  The
entire first and second arguments need to be swapped, not just the sg.width()
and sg.height() calls.

> I'm going to write test cases for [min-|max-|]device-aspect-ratio and fix the
> variable names.

Test cases are a Good Thing(tm).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.