[Webkit-unassigned] [Bug 15860] New: add() could use additional speedups

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15860

           Summary: add() could use additional speedups
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
 BugsThisDependsOn: 15837


add() could use additional speedups

Some suggestions brought up in bug 15837 but not implemented, include:

1.  Combine both types into a "type mask" using uint32_t typeMask = t1 << 3 |
t2; and then check the resulting type mask instead of t1 == StringType && t2 ==
StringType
2.  Speed up addSlowCase by passing in the typeMask and only calling
toPrimative when needed
3.  Speed up addSlowCase by avoiding calling toString() and using
static_cast<StringImp*>(foo)->value() when possible.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.