[Webkit-unassigned] [Bug 15837] New: AddNode causes excessive mallocs due to add() using toString(exec)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15837

           Summary: AddNode causes excessive mallocs due to add() using
                    toString(exec)
           Product: WebKit
           Version: 523.x+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


AddNode causes excessive mallocs due to add() using toString(exec)

add(exec, value1, value2) uses toString(exec) to create a UString from a
StringImp.  This is quite unfortunate as it causes creation of unnecessary
UStrings which are the immediately discarded.  It would be more efficient to
static cast to a StringImp* and call value() directly.  I'm not 100% sure
that's safe however. (I'm not sure if the design is supposed to allow other
subclasses of JSValue to return true for isString()... I don't think it
should.)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.