[Webkit-unassigned] [Bug 15682] Move wx port to TOT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 14:56:27 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=15682





------- Comment #19 from kevino at theolliviers.com  2007-11-01 14:56 PDT -------
(In reply to comment #18)
> (From update of attachment 16922 [edit])
> +#include "Frame.h"
> +#include "Page.h"
> +#include "FocusController.h"
> +#include "FrameView.h"
> +#include "KeyboardEvent.h"
> +#include "MouseEventWithHitTestResults.h"
> +#include "PlatformScrollBar.h"
> +#include "RenderWidget.h"
> +#include "ClipboardWx.h"
> 
> Please alphabetize the #includes.
> 
> +namespace WebCore
> +{
> 
> The brace should go on the same line as "namespace".
> 
> +bool DragController::isCopyKeyDown()
> +{
> +    return false;
> +}
> 
> Perhaps you want to call notImplemented() here?
> 
> r=me, but please fix the above before checking in.
> 

Applied with all suggested changes made, thanks! :-) 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list