[Webkit-unassigned] [Bug 13947] Finish autogenerating the JS DOM traversal code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 23:34:08 PDT 2007


sam at webkit.org changed:

           What    |Removed                     |Added
  Attachment #14798|                            |review?
               Flag|                            |

------- Comment #1 from sam at webkit.org  2007-05-30 23:34 PDT -------
Created an attachment (id=14798)
 --> (http://bugs.webkit.org/attachment.cgi?id=14798&action=view)

I am a little uneasy about this patch and wouldn't mind some harsh reviewing of
it.  The part I am uneasy about is the changing of the NodeFilter parameter of
Document::createNodeIterator and Document::createTreeWalker to be regular
pointers instead of PassRefPtrs.  I did this becuase it makes generating a lot
easier and that is how parameters are generally passed for the bindings.  If
there is any slowdown or other issues that this might cause I am sure I can
come up with a work around in the bindings scripts, but I thought I would check
if this way was OK first.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list