[Webkit-unassigned] [Bug 13913] FrameView::clear doesn't reset m_slowRepaintObjectCount leading to 'sticky' static background

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 15:36:30 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13913





------- Comment #2 from freyther at handhelds.org  2007-05-30 15:36 PDT -------
It works on the mac because Safari is creating a new FrameView for each site. I
have added the following patch and the amount of failed layout tests didn't
change.
I believe this patch is correct, it is a way without throwing away a frameview
to disable static backgrounds when leaving a site that required them.

Three things to consider:
   -Maybe it is better to make sure FrameView::removeSlowRepaintObject gets
called often enough from FrameLoader::clear?
   -Check if more attributes needs to be reset.
   -Make it mandantory to recreate the FrameView?




Index: WebCore/page/FrameView.cpp
===================================================================
--- WebCore/page/FrameView.cpp  (Revision 21902)
+++ WebCore/page/FrameView.cpp  (Arbeitskopie)
@@ -71,6 +71,7 @@
     }
     void reset()
     {
+        m_slowRepaintObjectCount = 0;
         useSlowRepaints = false;
         borderX = 30;
         borderY = 30;


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list