[Webkit-unassigned] [Bug 13865] Making usage of the icon database optional

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 10:48:15 PDT 2007


------- Comment #8 from beidson at apple.com  2007-05-25 10:48 PDT -------
I suppose I had two points -

re: SQL vs CG, my point was there are *CG only* files that are simply not
included in non-CG builds - the same pattern holds for a lot of other platform
or library specific files.

My main point was re: the uglification of the IconDatabase code.  We try to
keep our cross-platform .cpp files as clean as possible and I like that!  Some
of the really complicated, large classes can't help but have some #ifdef blocks
creep in there, but we largely avoid it by subclassing or splitting
implementations between platform specific and non-specific files.

I'm not saying that we don't care about platforms without sqlite and that we
shouldn't make a fix here to support them - I'm just saying this solution is

Perhaps reorganizing the header, putting a few intelligent #ifdefs there, then
having two implementation files would be better.  IconDatabaseSqlite and
IconDatabaseNone (the names need a little work..)  :)

You could then conditionally comment out one or the other implementation file
based on the new flag.

Still suboptimal, but a lot prettier...

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list