[Webkit-unassigned] [Bug 13865] Making usage of the icon database optional

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 09:58:31 PDT 2007


------- Comment #3 from beidson at apple.com  2007-05-25 09:58 PDT -------
I really don't like this approach.  Normally we #ifdef out pieces of larger
overall features for varying platforms, but this is nuking *an entire* feature
by scattering ifdefs over all of its code.

Something that would make me a lot happier would be to have separate skeleton
files with the blank implementations and have it defined at the project file
level.  That might not be ideal, either, but conditionally ifdefing out entire
source files like this is less ideal imho.

For example, though, taking the separate file approach you shouldn't even need
to touch SQLDatabase* stuff at all - #ifdefing out SQLite utilities on a
platform without SQLite is silly - that'd be like #ifdefing out CG utilities on
non-CG platforms.  

You just don't include those files!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list