[Webkit-unassigned] [Bug 10161] REGRESSION: form state not restored when going back to a page with frames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 18:28:35 PDT 2007


mpComplete at gmail.com changed:

           What    |Removed                     |Added
                 CC|                            |mpComplete at gmail.com

------- Comment #3 from mpComplete at gmail.com  2007-05-24 18:28 PDT -------
I just noticed this as well.  From stepping through the code, it looks like the
documentState is available on the HistoryItem initially when you navigate back,
but is overridden with empty data before it is restored.

Here's what I think is happening.  Since the frames don't exist yet when you
hit Back, they need to be created.  FrameLoader::init() is called, creating an
empty document for its new frame.  At this point,
FrameLoader::restoreDocumentState() is called, to restore the document state of
the original forms into the empty document.  This fails because the load is
still provisional, and restoreDocumentState only grabs from the
currentHistoryItem, which is NULL.

Then, when the Back navigation is committed, the document state for the empty
document is saved onto the HistoryItem corresponding to the subframe with form
data.  Shortly after, restoreDocumentState is called again, but by this point
the documentState is already clobbered.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list