[Webkit-unassigned] [Bug 13830] Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13830


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14692|review?                     |review+
               Flag|                            |




------- Comment #12 from darin at apple.com  2007-05-23 15:54 PDT -------
(From update of attachment 14692)
+        return toJS(exec, node);
+    } else if (!collection->length())
+        return jsUndefined();

No need for an else here. It would also be nice not to call
collection->length() twice.

+        // FIXME: Create an [NoOp] property for legacy functions that do
nothing like this.

I don't agree that we want to do this. Lets keep the binding layer as simple as
possible. I know it's complicated, but lets not make it more complicated except
for when we have to.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.