[Webkit-unassigned] [Bug 13830] Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 09:18:10 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13830


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14674|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2007-05-23 09:18 PDT -------
(From update of attachment 14674)
-        case ElementInnerText:
-            impl()->document()->updateLayoutIgnorePendingStylesheets();
-            return jsString(element.innerText());

I see that innerText calls it if renderer() is non-0, but can it sometimes make
renderer be non-0? If so, then this changes behavior.

+                 // So we use don't convert null to JS null.

I think you need to omit the word "use" here. It would be even easier to
understand if you mentioned the attribute that we're not using.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list