[Webkit-unassigned] [Bug 13842] Simplify Color::light() and Color::dark()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 07:57:13 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13842


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14684|review?                     |review-
               Flag|                            |




------- Comment #3 from darin at apple.com  2007-05-23 07:57 PDT -------
(From update of attachment 14684)
Does this really give the same values as before? If so, seems fine. But I was
under the impression that scaling value didn't affect the 3 channels equally.

I don't think dark() properly handles the case where all three of r, g, and b
are zero. So review- because of that. Otherwise, would be r=me.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list