[Webkit-unassigned] [Bug 13830] Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 14:43:07 PDT 2007


------- Comment #2 from sam at webkit.org  2007-05-22 14:43 PDT -------
There are two possible places of concern with this patch.  The first is change
to generate HTMLElement.innerText which had a call to
impl()->document()->updateLayoutIgnorePendingStylesheets(); and now does not. 
The implementation does the same call but does some stuff before it that might
cause issues. 

A second place for concern is with removing the following from the generator

-        if ($dataNode->extendedAttributes->{"HasNameGetter"} ||
$dataNode->extendedAttributes->{"HasOverridingNameGetter"}) {
-            # if it has a prototype, we need to check that first too
-            push(@implContent, "    if (prototype()->isObject() &&
static_cast<JSObject*>(prototype())->hasProperty(exec, propertyName))\n");
-            push(@implContent, "        return false;\n");
-        }

This code caused an incorrect prototype chain in the only other place that
[HasOverridingNameGetter] was used and testing the code without it doesn't
cause any regressions.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list