[Webkit-unassigned] [Bug 13825] [CAIRO] Implement PathCairo

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13825


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14663|review?                     |review-
               Flag|                            |




------- Comment #5 from oliver at apple.com  2007-05-22 14:10 PDT -------
(From update of attachment 14663)
I'm looking at this and i don't like the need to have different handling  of
the PlatformPath, and currently it looks like you're begging for memory leaks.

i would suggest
typedef struct cairopath { 
    cairo_t* m_context; 
    cairopath() {
        cairo_surface_t* pathSurface =
cairo_image_surface_create(CAIRO_FORMAT_A8, 1, 1);
        m_cr = cairo_create(pathSurface);
        moveTo(FloatPoint(0, 0));
    }
    ~cairopath() {
        //appriate delete stuff
    }
} PlatformPath;

then do everything in terms of that, that way you don't need ifdefs in the
actual definition part of the header. 

This is an ugly ugly byproduct of cairo's borked path api :-/

It's far to similar to the canvas api for my liking :-(


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.