[Webkit-unassigned] [Bug 13599] Scripts to generate coverage information for WebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 19 16:13:33 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=13599
bdash at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14613|review? |review-
Flag| |
------- Comment #26 from bdash at webkit.org 2007-05-19 16:13 PDT -------
(From update of attachment 14613)
Code like:
die unless (system "...") eq 0;
feels quite unnatural. It would read better if it were:
system("..") == 0 or die;
Is it really necessary to do find . -name '*.gc*' at the top of the WebKit
source tree? Are the *.gc* files not limited to certain directories? Even if
not, omitting LayoutTests from the search path would make this step a bit
quicker.
+my $resultName = $svnVersion."-".join('_', @timeData);
Whitespace between operators would be great.
Other than these stylistic issues I see no major issues.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list