[Webkit-unassigned] [Bug 13732] prepare-ChangeLog should work with git

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 16:57:01 PDT 2007


------- Comment #6 from aroben at apple.com  2007-05-15 16:57 PDT -------
(In reply to comment #5)
> (From update of attachment 14568 [edit])
> Overall this patch looks great!  I assume you've been living on it for a while,
> Adam?

   Yep, and it seems to be working nicely, modulo a few FIXMEs in the script.

> A couple comments:
> - Shouldn't %svn in isModifiedOrAddedStatus() also contain "R" for replaced
> files?

   Yes. Fixed.

> - Using diffHeaderFormat() within loops (when it returns the same value each
> time) and redefining local data structures for each method call (like in
> isModifiedOrAddedStatus() and isConflictStatus() and statusDescription()) makes
> me cringe, but unless there is an apparent slow down, it's nice not to have to
> declare global variables that are farther away from the subroutines.

   I'd guess that, as you said, these won't slow things down much.

   Thanks for the review!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list