[Webkit-unassigned] [Bug 13732] patch to make prepare-ChangeLog work with git

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 16:42:13 PDT 2007


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
  Attachment #14568|review?                     |review+
               Flag|                            |

------- Comment #5 from ddkilzer at webkit.org  2007-05-15 16:42 PDT -------
(From update of attachment 14568)
Overall this patch looks great!  I assume you've been living on it for a while,

A couple comments:

- Shouldn't %svn in isModifiedOrAddedStatus() also contain "R" for replaced

- Using diffHeaderFormat() within loops (when it returns the same value each
time) and redefining local data structures for each method call (like in
isModifiedOrAddedStatus() and isConflictStatus() and statusDescription()) makes
me cringe, but unless there is an apparent slow down, it's nice not to have to
declare global variables that are farther away from the subroutines.

- I understand the reason for declaring $isSVN, $isGit and $gitRoot next to
their methods, but I'm torn about not having them at the top of the script,
too.  They're okay, though.

r=me if you address "R" in %svn in isModifiedOrAddedStatus().

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list