[Webkit-unassigned] [Bug 13734] svn-create-patch could check for most obvious mistakes in patches

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13734





------- Comment #1 from kimmok at iki.fi  2007-05-15 11:24 PDT -------

I don't know if it'd be useful to others, but I'll probably save following
locally:

Index: WebKitTools/Scripts/svn-create-patch
===================================================================
--- WebKitTools/Scripts/svn-create-patch        (revision 21458)
+++ WebKitTools/Scripts/svn-create-patch        (working copy)
@@ -228,6 +228,10 @@ sub generateDiff($$$)
     close DIFF;
     $patch = fixChangeLogPatch($patch) if basename($file) eq "ChangeLog";
     print $patch if $patch;
+    if ($patch =~ /^\+(\t|!\+.*\t)/mg ) {
+        print STDERR "Warning: changes in file '$file' contain tab
characters.\n";
+    }
+
     if ($isBinary) {
         print "\n" if ($patch && $patch =~ m/\n\S+$/m);
         outputBinaryContent($file);


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.