[Webkit-unassigned] [Bug 13722] Finish testing and fixing the setting of DOM attributes to JS null

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 10:46:38 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13722


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14570|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-05-15 10:46 PDT -------
(From update of attachment 14570)
How about using dumpAsText for this test?

         [ConvertNullStringTo=Null, OldStyleObjC] DOMString substringData(in
[IsIndex] unsigned long offset, 
-                                                           in [IsIndex]
unsigned long length)
+                                                                         in
[IsIndex] unsigned long length)

I'm not a big fan of "high-maintenance" formatting that requires changes to
indentation when you rename things or add keywords. Maybe we can reconsider the
way we're formatting .idl files at some point.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list